Commons talk:CropTool

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search
This is the talk page for discussing improvements to Commons:CropTool.
Notice Maintenance notice
Maintenance for this tool is at https://github.com/danmichaelo/croptool - please do not report bugs in Phabricator tasks. You can see the last edit it tagged here.

Lossless mode no longer working?[edit]

@Danmichaelo, is lossless mode still working. I used to get messages that the crop size had been adjusted because I wasn't starting on a multiple of 8 or 16, but this has gone away. Similarly, there's a bug report on github (#170) reporting that files that should be uncroppable in lossless mode are now working, but produce the same files as if they were in precise mode. Is the tool silently falling back to precise when lossless doesn't work (which would be undesirable), or is something else going on here? Perhaps a bug introduced in the September 2020 refactoring? Ahecht (TALK
PAGE
) 14:59, 15 June 2022 (UTC)Reply[reply]

Looking into the code more, it seems like the September 2020 refactor fundamentally broke things. The various types of crop were broken out into subclasses (for example, lossless Jpeg cropping was broken out into JpegFile and Gif cropping to GifFile), but as far as I can tell the only subclasses that are actually being called out by the program in FileRepository.php are TiffFile, DjvuFile, PdfFile, and SvgFile, all of which return errors instead of actually working. All other file types are being handled by the generic imagemagick call in File.php.
This is why lossless crops are no longer lossless, Gif files say they are being cropped with precise or lossless mode instead of "gif mode", and TIFFs, PDFs, and DJVUs no longer work.
If these issues aren't easy to resolve, perhaps to the tool should be rolled back to 1.4 (before the refactoring). Ahecht (TALK
PAGE
) 14:18, 17 June 2022 (UTC)Reply[reply]
just confirming this issue persists 2023-01.--RZuo (talk) 11:53, 15 January 2023 (UTC)Reply[reply]
Since about 9-2021 Danmichaelo's only contributions have been edits to wikidata and some edits in norwegian and finnish wikipedia about some meta-topics (bot problems, ...). I seem to remember that them was unhappy with a decission at english wikipedia. That leaves two ways of action: Appease them to return to wikipedia, or find a new maintainer for croptool. Just waiting woll not help. C.Suthorn (talk) 15:34, 15 January 2023 (UTC)Reply[reply]
sigh :/
there were a few commits https://github.com/danmichaelo/croptool/commits/master .
i know someone might have to take over, but i reposted this thread because this is a major issue which should not be archived until it's resolved. RZuo (talk) 18:25, 15 January 2023 (UTC)Reply[reply]

WebP format support[edit]

Just realized that WebP format is not supported so requesting its support be added, thanks. Ohsin (talk) 05:33, 27 April 2023 (UTC)Reply[reply]

Ditto. SVTCobra 07:51, 26 May 2023 (UTC)Reply[reply]
Another one. In the meantime, can someone point me in the right direction of how to crop otherwise, I'm trying to get File:Jude Belligham vs Almería.webp in a better size for a portraint in a infobox. Ortizesp (talk) 07:19, 16 October 2023 (UTC)Reply[reply]

Structured Data[edit]

Is it possible to also copy structured data while cropping? Currently, if some data is only stored in structured data, it is lost. As an example, please see the coordinates for this picture: File:Bagdad Mine in Yavapai County, Arizona - ISS048-E-17035 - View of Arizona (cropped).jpg Schlurcher (talk) 18:54, 29 May 2023 (UTC)Reply[reply]

If this is done, there needs to be some control over it: for example, we don't necessarily want to copy "depicts" for things that are outside of the resulting crop. - Jmabel ! talk 20:52, 29 May 2023 (UTC)Reply[reply]

504 Gateway Time-out[edit]

CropTool isn't working for me. I get a "504 Gateway Time-out". Is something wrong with the tool, or is it a toolforge issue? Schwede66 00:09, 1 September 2023 (UTC)Reply[reply]

Also getting a timeout error! --Engineerchange (talk) 04:08, 1 September 2023 (UTC)Reply[reply]
Same problem. Mehedi Abedin 06:55, 1 September 2023 (UTC)Reply[reply]
@Schwede66: and @Mehediabedin: works for me now! --Engineerchange (talk) 14:34, 1 September 2023 (UTC)Reply[reply]
Excellent! Schwede66 14:38, 1 September 2023 (UTC)Reply[reply]

Received error: no-such-entity[edit]

I'm trying to crop https://croptool.toolforge.org/?title=Catherine_McCord.jpg - when I select the rectangle I want, and press "Preview" I get "[Error] [api] Received error: no-such-entity : Could not find an entity with the ID "##Q2942000"." --GRuban (talk) 20:26, 13 September 2023 (UTC)Reply[reply]

@GRuban: I cropped it to File:Catherine McCord (cropped).jpg with Jpegcrop for you, and replaced what I could. Usages should catch up eventually.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 13:01, 16 October 2023 (UTC)Reply[reply]
WikiThanks
WikiThanks
--GRuban (talk) 14:06, 16 October 2023 (UTC)Reply[reply]
@GRuban: You're welcome.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 17:49, 16 October 2023 (UTC)Reply[reply]

cropping fails after rotation of large files[edit]

When trying to rotate and crop the file for this, it failed. To work-around it, I cropped it in two steps.

I had the same problem when trying to crop the same region from another large file. Error message displayed was "[Error] undefined". Enhancing999 (talk) 09:56, 16 October 2023 (UTC)Reply[reply]

new option: crop from several tiles[edit]

Map tile #1165 is part of a series 250 tiles.

Sometimes one would want to crop an area stretching across two adjacent tiles (with the one left, right, above or below).

Ideally, one would specify two files with their alignment and then be able to crop from both at once. Enhancing999 (talk) 10:01, 16 October 2023 (UTC)Reply[reply]

  • Can't really expect this tool to do everything. Download to your computer and do that in GIMP, Photoshop, etc. - Jmabel ! talk 23:48, 16 October 2023 (UTC)Reply[reply]

Feature request re updating of Template:Image extracted[edit]

Currently this tool will usefully add or update {{Image extracted}} on existing file pages when a crop is generated. However, this is unnecessary when the new crop overrides an existing one, and which is already listed in the template at the source file page. A useful feature request is to suppress the updating of {{Image extracted}} when the cropped image is already listed there. — RAVENPVFF · talk · 16:57, 8 November 2023 (UTC)Reply[reply]

Grid engine will shut down on December 14th, tool will stop working[edit]

@Danmichaelo, per https://grid-deprecation.toolforge.org/t/croptool, croptool is still running on Grid Engine. This will be shutting down in less than two weeks unless the developer applies for an extension, in which case it would shut down next February. Unless something is done, this tool will stop functioning at that time. See https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/VIWWQKMSQO2ED3TVUR7KPPWRTOBYBVOA/ Ahecht (TALK
PAGE
) 15:53, 2 December 2023 (UTC)Reply[reply]

This seems quite important, and I will also post it on the Village pump.- Jmabel ! talk 17:58, 2 December 2023 (UTC)Reply[reply]
See also wikitech:News/Toolforge Grid Engine deprecation.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 13:32, 3 December 2023 (UTC)Reply[reply]
Issue logged at https://github.com/danmichaelo/croptool/issues/190 - Jmabel ! talk 19:07, 3 December 2023 (UTC)Reply[reply]
i saw a commit last year called "Move jobs to kubernetes" https://github.com/danmichaelo/croptool/commit/9a8e9a2849d3df0513b84137c8b863199fad9dc1 . :/ --RZuo (talk) 06:30, 7 December 2023 (UTC)Reply[reply]
I’m surprised, and concerned, that this hasn’t attracted more attention so far. Is this good news, though? -- Tuválkin 16:07, 9 December 2023 (UTC)Reply[reply]
@Tuvalkin: https://phabricator.wikimedia.org/T319653#9387586 certainly is.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 02:50, 10 December 2023 (UTC)Reply[reply]
what's happening on 14 dec? is the tool migrated? or is it extended to 14 feb? RZuo (talk) 18:45, 11 December 2023 (UTC)Reply[reply]
@RZuo: Extended unless phab:T319653 is completed in time.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 19:15, 11 December 2023 (UTC)Reply[reply]
i saw https://github.com/danmichaelo/croptool/pull/182 . i was wondering, since migration is still being worked out, would User:Christoph Jauera (WMDE) and User:TMg maybe want to consider forking and rehosting the tool, in case it's at risk of being discontinued? RZuo (talk) 19:28, 11 December 2023 (UTC)Reply[reply]
@Danmichaelo, @RZuo, @Jeff G.,
What is the current status of the Commons crop tool? Has Grid Engine been migrated over to Kubernetes yet? Is this relevant- https://phabricator.wikimedia.org/T313550 ? -- Ooligan (talk) 17:24, 12 January 2024 (UTC)Reply[reply]
@Ooligan: From what I can see, Dan has been given more tools, we are waiting for him.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 10:23, 13 January 2024 (UTC)Reply[reply]

Crop Tool has not been working for hours today.[edit]

Fyi, @Danmichaelo, @RZuo @Jeff G. After clicking, the tool does not load the image to be cropped. Thanks, -- Ooligan (talk) 05:44, 21 January 2024 (UTC)Reply[reply]

same for me. https://croptool.toolforge.org keeps loading without any progress. RZuo (talk) 09:25, 21 January 2024 (UTC)Reply[reply]
@Ooligan: Right, you had the last upload 00:01, 21 January 2024 (UTC), ten hours ago. That URL times out for me.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 10:02, 21 January 2024 (UTC)Reply[reply]

Not working![edit]

For me, visiting the Toolforge site or clicking the tool on the sidebar results in a screen saying "Wikimedia Toolforge Error" BhamBoi (talk) 23:41, 21 January 2024 (UTC)Reply[reply]

@BhamBoi: Right, "Wikimedia Toolforge Error
This Grid Engine web service cannot be reached. Please contact a maintainer of this tool."   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 00:55, 22 January 2024 (UTC)Reply[reply]
Yes, that's the message I've see, too. --Rosiestep (talk) 13:17, 22 January 2024 (UTC)Reply[reply]
Same for me. Any idea when this will be fixed? TurboGUY (talk) 13:39, 22 January 2024 (UTC)Reply[reply]
@Rosiestep, @BhamBoi,@TurboGUY,@Jeff G., @Leonprimer. See https://phabricator.wikimedia.org/T314664
This link has a volunteer in April 2023 noting that "Migrate remaining tools off Gridengine" is "in progress" here: https://phabricator.wikimedia.org/T313405 (and still in progress with regards to the popular and unique CropTool), while the "GridEngine" was noted on 22 January by fnegri as Toolforge: Decommission the Grid Engine infrastructure.
Question: I'm not technically astute, but shouldn't the "in progress" tool migration off the GridEngine be completed or "closed" before "decommisioning" that GridEngine?
Additionally, the Category:Extracted images has 651,000+ files. I'm guessing the vast majority related to the currently orphaned and still needed- CropTool. Thank you, Ooligan (talk) 01:54, 23 January 2024 (UTC)Reply[reply]
Also, The Wikitech "timeline" states that GridEngine will stop on February 14, 2024, not January 21, 2024 (three weeks premature?) here: https://wikitech.wikimedia.org/wiki/News/Toolforge_Grid_Engine_deprecation Ooligan (talk) 02:10, 23 January 2024 (UTC)Reply[reply]
@Ooligan: Yes, of course the "in progress" tool migration off the GridEngine should be completed or "closed" before "decommisioning" that GridEngine.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 02:21, 23 January 2024 (UTC)Reply[reply]

From yesterday the tool doesn't work. I opened an issue at https://github.com/danmichaelo/croptool/issues but it seems @Danmichaelo: didn't read it. Does know anybody how to reach him? He's the developer of the tool. Leonprimer (talk) 16:22, 22 January 2024 (UTC)Reply[reply]

Please note that Dan has not edited Commons since 15:18, 14 November 2023 (UTC), 2 months, 8 days, 11 hours and 51 minutes ago (69 days).   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 03:09, 23 January 2024 (UTC)Reply[reply]
Tool seems to be back up. Sjoerd de Bruin (talk) 08:33, 23 January 2024 (UTC)Reply[reply]
Working for me now too. I wonder what the problem was? TurboGUY (talk) 10:35, 23 January 2024 (UTC)Reply[reply]
@Sjoerddebruin and TurboGUY: Responding for me, too. The first upload in three days was today at 08:08 (UTC). Thanks for the reports.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 11:07, 23 January 2024 (UTC)Reply[reply]
Just want to say thank you, as I use this tool almost every day. --Rosiestep (talk) 18:34, 23 January 2024 (UTC)Reply[reply]
February 14
is the latest apparent deadline for final resolution of CropTool's future, per https://phabricator.wikimedia.org/T319653 ----- Quote: "The [[ https://wikitech.wikimedia.org/wiki/News/Toolforge_Grid_Engine_deprecation | planned grid shutdown date ]] is February 14th.
Seems like right now the webservice [[ https://sal.toolforge.org/log/vwRYNY0BxE1_1c7syK2M | just needed a restart ]], at least the interface loads now.''"
  • So, what is the plan to get this CropTool migration completed and resolved?
  • Can or should Wikimedia Foundation staff help to "save" CropTool? --Ooligan (talk) 15:30, 24 January 2024 (UTC)Reply[reply]
    • @Sannita (WMF): any chance someone can look into this before it quite likely becomes a crisis in three weeks? - Jmabel ! talk 20:14, 24 January 2024 (UTC)Reply[reply]
      and someone cites "Valentine's Day" as a reason to procrastinate.   — 🇺🇦Jeff G. please ping or talk to me🇺🇦 23:06, 24 January 2024 (UTC)Reply[reply]
      @Jmabel to be completely honest, it's hardly possible to fix this problem in such a short time. It's extremely difficult that WMF will overtake the development of CropTool, as well as postponing the deprecation of the engine. Sannita (WMF) (talk) 12:28, 25 January 2024 (UTC)Reply[reply]
      • @Sannita (WMF): have you (or anyone you know of) heard anything from Dan on this? I'm wondering whether we should presume he is working on this or if it would make more sense to presume that the tool is abandoned. - Jmabel ! talk 18:59, 25 January 2024 (UTC)Reply[reply]
        from what i can tell in the phab tasks, migration to k8s is stalled due to missing dependencies? https://phabricator.wikimedia.org/T313550
        but User:Taavi closed that task.
        Dan says, "On Toolforge, I'm trying to get djvu working in CropTool again after having moved to kubernetes, but having a hard time. There's no compilers in the php7.4 image, so I was recommended to try the rub27 image. I was able to compile things there, but not to get the binaries to run in the php7.4 image due to missing shared libraries. It's probably possible to create fully standalone binaries that don't depend on shared libraries, but it's a bit beyond my knowledge (I tried adding a --disable-shared flag). It would be very helpful if compilers could be added to the php7.4 image, what's the process for requesting that?" https://wm-bot.wmcloud.org/logs/%23wikimedia-cloud/20220721.txt
        take note this chat was back in july 2022... RZuo (talk) 20:28, 25 January 2024 (UTC)Reply[reply]